What I’ve done:

All of my passwords and passkeys are in Bitwarden. My brother has emergency access, and I’ve documented in Bitwarden Secure Notes my device credentials, recovery codes, estate information, and instructions for accessing my accounts.

One unresolved issue:

I have private photos of current romantic partners in my iOS Photos hidden album. I want my next of kin to be able to access the rest of my digital life, but I also want to protect those people’s privacy.

As far as I know, Apple doesn’t provide a way to grant next-of-kin access to an account while excluding hidden photos.

My current solution is a note asking my brother to delete the hidden photos before looking through the rest of my account. I trust him to do that, but I’d prefer a technical solution.

Is there a better approach?

I think the biggest edge case is not having a way to test the process. I also think that if you're concerned about it, you should have a recurring (annual perhaps) exercise to make sure everyone involved remembers what to do.