21 pointsby asmodios3 hours ago3 comments
  • idoubtit39 minutes ago
    I expected a toy project, but it is a usable library, which required a lot of work. Good job on delivering. A few comments:

    After reading "composer.json", I thought that the tests used a custom framework. I'm glad the project does not suffer from NIH syndrome, but the dev dependency on PHPUnit should be declared.

    There should a warning that it's only meant for some Western Latin languages. The normalization of the input is built on a character table for a handful of cases. That's not enough for some Latin languages, e.g. Turkish. And any input with Cyrillic, Arabic, CJK and so on, will be ignored.

    There is no Unicode normalization or cleanup. Real-life input have many corner cases, e.g. diacritics next to the characters, or invisible characters inside a word to prevent hyphenation. Unless I'm mistaken, this engine would treat the NFD form "fête" as "fe te", instead of the expected "fete", which the NFKD form "fête" produces. I suggest using ext-intl for Unicode normalization, at least as an option.

    Lastly, I can't think of a use case for this library. I've always had access to some external service (MySQL, Postgresql, Manticore Search, Solr, etc.) or to a PHP extension for a local Sqlite with FTS. Even for hobby projects, I haven't deployed to a shared hosting for more than two decades.

  • captn3m0an hour ago
    Zend used to maintain a PHP port of Lucene 15 years ago that I used, but not sure what happened to it.
    • asmodiosan hour ago
      Yes, Zend_Search_Lucene was dropped from Zend Framework 2 and never officially maintained for modern PHP. There's a community fork.
  • cpollett2 hours ago
    code looks pretty clean. is small and compact, decent benchmarks. might want to consider using an autoloader for classes.
    • hparadiz2 hours ago
      The PSR-4 definition is properly defined in composer. There's no need to include an autoloader. Any project pulling this in would have it's own.