Many patent trolls are really trolls. But being a "non-practicing entity" doesn't make you bad. For instance an academic research group might invent a technology that is useful in making microchips but only a few companies are capable of benefiting from that so that research group/Uni is a "non-practicing entity" that can license the tech fairly to one of those companies.
You often see things like this garden hose
https://pockethose.com/pages/copper-head?variant=44089443483...
that are marketed under the "as seen on TV" brand. The company behind that licenses patents from inventors and they feel like they can invest in marketing and development because the patent holds back cheap competition.
In the case of that hose, competitors figured out other ways to make a hose that does something similar and you see a common scenario -- that page boasts about all the improvements they've made in the product, starting out with one patent helps them lead in a competitive market in which they've gotten many more patents to improve their product.
My take is a lot of patents are really poor quality. (Worked on a patent search engine so I have looked at a lot of them)
This year I took an interest in Heart Rate Variability biofeedback and developed my own system which I haven't found in the literature (patent or otherwise) [1]
I have looked at a lot of patents on the subject and to me they are trash. They blather on with literature reviews, describe complex systems which violate all the principles of biofeedback (e.g. like they have you do "resonant breathing" at a fixed frequency or compute scores over a 2 min interval rather than look at the biosignal in real time which is the basic principle of biofeedback -- if I just want some metric to measure my health I will take my blood pressure the way my doc wants me to!)
It's shocking because I can't believe any of these people ever seriously tried it!
Maybe a percent or so of patents are well-written, clear, beautifully illustrated and describe genius inventions. My favorite is this one
https://patents.google.com/patent/US3733309A/en
which is for the plastic PET bottle of which half a trillion or so are made a year -- something brilliant and demonic (in terms of waste) at the same time!
---
[1] to document as prior art: a healthy heart has variations of HR over a time scale of 10s or so called the Mayer Oscillation. The amplitude of this oscillation can be estimated by averaging the metric known as SD1 over a 20s interval:
https://pubmed.ncbi.nlm.nih.gov/28073153/
You can increase the amplitude of you Mayer oscillation by: plot instantaneous heart rate (1/R-R interval) as a function of time; watch the slope beat by beat, if your heart rate falls breathe out, if it rises, breathe in. if your Mayer oscillation is weak you might have a hard time doing it and feel short of breath for a moment but usually your Mayer oscillation quickly strengthens (less than 1 min) and once it is strong it is very easy to keep pacing.